Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These are enabled by default in Ember CLI 3.5 #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hakubo
Copy link

@hakubo hakubo commented Oct 18, 2018

No description provided.

@gossi
Copy link
Owner

gossi commented Oct 18, 2018

That is true, but not everybody has upgraded to ember-cli 3.5 as of now, that's why they are still in. To make this cool, you can check for the ember version and remove them, when this is new enough.

@gossi
Copy link
Owner

gossi commented Oct 18, 2018

@hakubo looks cool. Can you explain, why you put (Broken) into the commit message?

@hakubo
Copy link
Author

hakubo commented Oct 18, 2018

Because I don't think it'll work :)
new VersionChecker(this); need an instance of an addon that we don't have here
I have asked how we could use that outside normal ember addon here
ember-cli/ember-cli-version-checker#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants